Update Gradle Command Test to Only Accept Gradle Declarative Apply #8325
+46
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesswrd
added
override: no versioning needed
jesswrd
force-pushed
the
i1152656-update-repo-tooling-tests
branch
from
b1fd75a to
2825aa0
Compare
jesswrd
force-pushed
the
i1152656-update-repo-tooling-tests
branch
from
2825aa0 to
46428e6
Compare
|
@reidbaker Requested review with a failing test, but it looks unrelated to my changes. It's from tip of tree. |
jesswrd
changed the title
reidbaker
approved these changes
Dec 19, 2024
jesswrd
force-pushed
the
i1152656-update-repo-tooling-tests
branch
from
665422d to
e30495e
Compare
jesswrd
added
the
autosubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the tests accept both the old gradle imperative apply and the gradle declarative apply. Since all plugins have been migrated to the gradle declarative apply, we want all exmple app plugins to reflect that and only accept gradle declarative apply.
Fixes flutter/flutter#152656
Fixes flutter/flutter#157660
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.